Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Theming - Spectrum variable mapping and light theme #1680

Merged
merged 30 commits into from
Dec 22, 2023

Conversation

bmingles
Copy link
Contributor

@bmingles bmingles commented Dec 8, 2023

Theming - Spectrum variable mapping

resolves #1669

resolves #1539

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (73e0b65) 46.67% compared to head (4d45c0c) 46.69%.

Files Patch % Lines
.../code-studio/src/styleguide/SpectrumComparison.tsx 75.00% 5 Missing ⚠️
packages/code-studio/src/styleguide/Buttons.tsx 0.00% 2 Missing ⚠️
packages/code-studio/src/styleguide/hooks.ts 50.00% 2 Missing ⚠️
packages/components/src/Button.tsx 50.00% 2 Missing ⚠️
packages/components/src/theme/Logo.tsx 0.00% 2 Missing ⚠️
packages/grid/src/GridRenderer.ts 33.33% 2 Missing ⚠️
...ackages/code-studio/src/styleguide/SamplesMenu.tsx 94.11% 1 Missing ⚠️
packages/code-studio/src/styleguide/Swatch.tsx 0.00% 1 Missing ⚠️
...d-core-plugins/src/linker/LinkerOverlayContent.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1680      +/-   ##
==========================================
+ Coverage   46.67%   46.69%   +0.02%     
==========================================
  Files         606      608       +2     
  Lines       36873    36913      +40     
  Branches     9267     9279      +12     
==========================================
+ Hits        17211    17238      +27     
- Misses      19610    19623      +13     
  Partials       52       52              
Flag Coverage Δ
unit 46.69% <72.30%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmingles bmingles force-pushed the 1669-spectrum-theme-variables branch from 013533d to 7bf0f29 Compare December 12, 2023 20:00
@dsmmcken dsmmcken marked this pull request as ready for review December 21, 2023 22:44
@dsmmcken dsmmcken changed the title feat: Theming - Spectrum variable mapping feat: Theming - Spectrum variable mapping and light theme Dec 21, 2023
@dsmmcken dsmmcken requested a review from mofojed December 21, 2023 22:45
@mofojed mofojed merged commit 2278697 into deephaven:main Dec 22, 2023
5 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@bmingles bmingles deleted the 1669-spectrum-theme-variables branch February 27, 2024 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Theming - Spectrum variable mapping Theming - Base Light Theme
3 participants